feat(frontend): revamp contacts page design#1728
Open
Shadow243 wants to merge 18 commits intocypht-org:masterfrom
Open
feat(frontend): revamp contacts page design#1728Shadow243 wants to merge 18 commits intocypht-org:masterfrom
Shadow243 wants to merge 18 commits intocypht-org:masterfrom
Conversation
Shadow243
force-pushed
the
revamp-contacts-page
branch
from
5b84377 to
cfd07f2
Compare
…tton state management
Shadow243
force-pushed
the
revamp-contacts-page
branch
from
c55f51b to
753f6dc
Compare
…nhance contact handling
…ity and update styles for improved layout
…rm validation improvements
…ion in contact form
Member
Author
|
@kroky I’ve refactored the contact page UI. There are still some TODOs related to form validation in site.js. You can proceed with the review; I’ll add the correct messages and remove the TODOs from the code. |
Shadow243
commented
Jan 5, 2026
| * @subpackage import_local_contacts/output | ||
| * This class is now deprecated as CSV import is integrated into Hm_Output_contacts_form | ||
| */ | ||
| class Hm_Output_import_contacts_form extends Hm_Output_Module { |
Member
|
Looks good on first sight but please finish it with everything you think is TODO and then I will do a more thorough review before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revamp Cypht contact page.
ref: 3bfe50b#r164832995
Before:
After:
LDAP Contacts list:
TODO
Remove and fix all TODOs related to alert validation messages in site.js
Add Pagination to contact listMove ldap contact modal form and JS to /modules/ldap_contacts/Move local contact modal form and JS to /modules/local_contacts/