Skip to content

Conversation

@oliver-sanders
Copy link
Member

Upgrade to the last good version of apexcharts.

The licence was still MIT @ 4.7.0: https://github.com/apexcharts/apexcharts.js/blob/v4.7.0/LICENSE

After which it went evil, hence #1978 cannot be merged.

@ChrisPaulBennett, please can you review this and make sure the upgrade hasn't broken anything, if changes are needed, push them to this branch. @MetRonnie noted panning issues (#1978 (comment)), although, having tested, I'm not sure panning works on master either?

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added the dependencies Pull requests that update a dependency file label Jan 13, 2026
@MetRonnie MetRonnie added javascript Pull requests that update Javascript code analysis views Work pertaining to the analysis/gantt/etc views labels Jan 14, 2026
@MetRonnie
Copy link
Member

Panning in the Gantt chart is still broken, might be apexcharts/apexcharts.js#4975

To reproduce: scroll with mouse wheel over the gantt view. The chart disappears entirely!

@oliver-sanders
Copy link
Member Author

Yep - #2256, frustrating.

Guessing it's no worse than before?

@MetRonnie
Copy link
Member

MetRonnie commented Jan 27, 2026

Not reproduced that before other than when apexcharts is upgraded.

Edit: reproduced on master by deliberately zooming in order to make the data go off the edges. But on this branch it's a lot worse as it happens on the slightest scroll

@oliver-sanders
Copy link
Member Author

This is probably going to serve as the blocker PR for all apexcharts upgrade.

  • Can't move to v4 because of bugs.
  • Can't move to v5 because of license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analysis views Work pertaining to the analysis/gantt/etc views blocked dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants