Control page change with a key in state#221
Open
ftaiolivista wants to merge 1 commit intocyclejs-community:masterfrom
Open
Control page change with a key in state#221ftaiolivista wants to merge 1 commit intocyclejs-community:masterfrom
ftaiolivista wants to merge 1 commit intocyclejs-community:masterfrom
Conversation
Currently any new history change trigger a page component regeneration. Sometimes may be helpful to update the url without trigger a page component recalc. Proposed solution use a key attribute in the history object state. If a key is present and the key of the new state is equal to the key of the old state the page component recalc is not triggered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently any new history change trigger a page component regeneration.
Sometimes may be helpful to update the url without trigger a page component recalc.
Proposed solution use a key attribute in the history object state.
If a key is present and the key of the new state is equal to the key of the old state the page component recalc is not triggered.