Add username and password handling from user mapping#33
Open
Hunaid2000 wants to merge 7 commits intomainfrom
Open
Add username and password handling from user mapping#33Hunaid2000 wants to merge 7 commits intomainfrom
Hunaid2000 wants to merge 7 commits intomainfrom
Conversation
Retrieve username and password from user mapping instead of server options.
'root' is a special role, so no need to grant permissions to it.
if-loop69420
requested changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Looks nice all in all. Good use of the pg_sys things even if they're unsafe, but there's no safe way to do it afaik. You've added tests and updated the docs, which I'm happy with. Please add the small change i suggested for the error message. Also sorry for taking so long to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User/password options are in server options which is not according to the standard. We retrieve username and password from user mapping instead of server options.
Those using this FDW need to enable auth, setup roles/users (like root) on etcd, as mentioned in docs. Then create a user mapping for that user with password like