Populate vulnerable_configuration by cpes even if vulnerable: false#325
Open
mikhailevtikhov wants to merge 1 commit intocve-search:masterfrom
Open
Populate vulnerable_configuration by cpes even if vulnerable: false#325mikhailevtikhov wants to merge 1 commit intocve-search:masterfrom
mikhailevtikhov wants to merge 1 commit intocve-search:masterfrom
Conversation
Collaborator
|
I think my thoughts on the other feature apply here as well. I’d suggest keeping the data unchanged during population and shifting the processing to query time, so that the results behave more like those from NIST. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
This PR extends the logic of point 1 from Additional analysis during populating CPEs in CVE. Similarly, while testing and comparing results from NIST and the database populated by CveExplore, I encountered the following case:
For example, when searching for
cpe:2.3:a:apache:http_server:2.4.29, NIST finds 16 more CVEs than cve-search:(
CVE-2007-4723, CVE-2009-0796, CVE-2009-2299, CVE-2011-1176, CVE-2011-2688, CVE-2012-3526, CVE-2012-4001, CVE-2012-4360, CVE-2013-0941, CVE-2013-0942, CVE-2013-2765, CVE-2013-4365, CVE-2021-32785, CVE-2021-32786, CVE-2021-32791, CVE-2021-32792).Example response from NIST API for CVE-2013-4365:
In this case, for
apache:http_server, thevulnerablekey is set tofalse. This condition does not pass theif cpeuri["vulnerable"]check in theprocess_the_itemmethod of theCVEDownloadsclass.If we incorporate the logic from point 1 of the previous PR into this PR, we can add references to these CPEs in
vulnerable_configurationwithout clutteringvulnerable_product.Is my understanding of the
vulnerable_configurationfield correct? In this case, a user would be able to determine whether their software is part of a vulnerable configuration. Alternatively, they could search byvulnerable_productsto find only those CVEs that are explicitly marked as affecting their software.After applying these changes along with the previous PR, the results of the local database and NIST became identical when searching via
vulnerable_configuration.