fix(server-core): Support config dict return from externalDriverFactory#10318
Open
UgoM wants to merge 1 commit intocube-js:masterfrom
Open
fix(server-core): Support config dict return from externalDriverFactory#10318UgoM wants to merge 1 commit intocube-js:masterfrom
UgoM wants to merge 1 commit intocube-js:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is my first PR on your repo, so don’t hesitate to help me improve it if I’ve done things wrong.
Check List
Issue
Fixes #10317
Description
external_driver_factoryin Python (cube.py) fails because it expects aBaseDriverinstance but Python can only return config dicts. This works fine fordriver_factorywhich has conversion logic inresolveDriver(), butexternalDriverFactorywas missing the same treatment.This PR adds the same config-to-driver conversion pattern used by
driverFactory:Now both factories behave consistently and Python users can use
external_driver_factorywith config dicts.