Fix function-summary printer incorrectly classifying internal calls as external#2993
Open
cats2101 wants to merge 1 commit intocrytic:masterfrom
Open
Fix function-summary printer incorrectly classifying internal calls as external#2993cats2101 wants to merge 1 commit intocrytic:masterfrom
cats2101 wants to merge 1 commit intocrytic:masterfrom
Conversation
The get_summary() method used external_calls_as_expressions, a heuristic that misclassifies dotted expressions like bytes.concat(), abi.encode(), and library calls as external calls. Replace with high_level_calls filtered to exclude LibraryCall, which is definitively correct. Closes crytic#2073
Author
|
Gentle ping — anything else needed here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
external_calls_as_expressionswith IR-basedhigh_level_callsfiltering (excludingLibraryCall) inget_summary()for bothFunctionContractandFunctionTopLevelexternal_calls_as_expressionsmatches any expression containing a., which misclassifiesbytes.concat(),abi.encode(), library calls, and similar dotted expressions as external callshigh_level_callsuses the SlithIR intermediate representation, which correctly distinguishes actual external contract calls from other dotted syntaxCloses #2073
Test plan
slither . --print function-summaryno longer listsbytes.concat(),abi.encode(), or library calls under external callstoken.transfer()) still appear correctly