chore: fix subprocess silence logic in compiler selection#1464
Open
mdqst wants to merge 1 commit intocrytic:masterfrom
Open
chore: fix subprocess silence logic in compiler selection#1464mdqst wants to merge 1 commit intocrytic:masterfrom
mdqst wants to merge 1 commit intocrytic:masterfrom
Conversation
Member
|
hi! out of curiosity, what prompted this change? do you use this script somewhere? and what issues did you see? (I'm not sure how the and/or pseudo-ternary could fail here, but I agree the if/else is clearer) I'm mainly asking as we only copy this script to the distroless docker target, and that is not a docker target we ever built on CI or people use. I've thought about removing it altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noticed a small issue in how we were setting
silentfor the compiler subprocess.previously it used a combination of
and/orwhich can lead to unexpected results.changed it to a clear ternary expression:
now the behavior is straightforward and consistent.