Digest: Public API (draft) #1140
Conversation
wysiwys
changed the title
franziskuskiefer
left a comment
franziskuskiefer
left a comment
There was a problem hiding this comment.
I'm not sure what the usages are exactly because of the missing docs. We should have public APIs that can do something like
// oneshot, algorithm specific
let digest = Sha256::hash(b"input");
// oneshot, "multiplexed"
let digest = Digest::hash(Algorithm::Sha256, b"input");
// oneshot, "multiplexed" with caller provided memory
let mut digest = [0u8; 32];
Digest::hash(Algorithm::Blake2b, &mut digest, b"input");
// incremental
let mut hasher = Sha256::new();
hasher.update(b"input");
let digest = hasher.finalize();
// or with caller provided memory
hasher.finalize(&mut digest);
// Similar for the "multiplexed" version.Without docs it's hard to tell if this is possible. But looking at the tests, this looks way more complex right now.
| @@ -0,0 +1,3 @@ | |||
| pub trait HashConsts { | |||
| const DIGEST_SIZE: usize; | |||
There was a problem hiding this comment.
Shall we add max input length here as well?
| @@ -0,0 +1,104 @@ | |||
| #[derive(Debug)] | |||
There was a problem hiding this comment.
Some doc comments would be nice 😊
| } | ||
|
|
||
| impl<Algo> DigestMut<'_, Algo> { | ||
| pub fn algo(&self) -> &Algo { |
There was a problem hiding this comment.
Maybe algorithm? algo sounds a little off.
| let algo = Blake2sHash::<RuntimeDigestLen>::default(); | ||
| let digest_mut = DigestMut::new_for_algo(algo, &mut digest).unwrap(); | ||
| algo.hash(digest_mut, b"this is a test").unwrap(); |
There was a problem hiding this comment.
This seems like a lot of code for just calling a hash function.
I'd want to call something like Blake2sHash::hash(digest_mut, b"this is a test"). It's not clear why the extra two lines are necessary.
|
This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
|
@wysiwys is this still something you work on or should it be closed? |
|
This PR has been marked as stale due to a lack of activity for 60 days. If you believe this pull request is still relevant, please provide an update or comment to keep it open. Otherwise, it will be closed in 7 days. |
jschneider-bensch
added
the
waiting-on-author
|
@wysiwys Can you say what the current state is, here? Did we merge something for this already somewhere else? |
|
This PR was an earlier draft to address issue #1039 for implementing the One thing that's implemented here that wasn't merged by another PR is providing an API in |
|
Thanks for the update! Yes, let's file an issue for runtime selection of digest algorithms and address it separately. 👍 |
3 participants
This pull request begins implementing a public Digest API with multiplexing (as part of #1039).
Hasherstruct initialization viaDigestIncrementalBase::new()libcrux_traits::digest::Hasherstructs in newlibcrux-digestcrateHashinlibcrux-digest