Skip to content

fix: reject nft-transfer sends on non-nft port#1252

Merged
songgaoye merged 7 commits intomasterfrom
song/nft-transfer-enforce-nft-port
Apr 2, 2026
Merged

fix: reject nft-transfer sends on non-nft port#1252
songgaoye merged 7 commits intomasterfrom
song/nft-transfer-enforce-nft-port

Conversation

@songgaoye
Copy link
Copy Markdown
Contributor

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.84%. Comparing base (f8a53d8) to head (c9dae84).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
x/nft-transfer/keeper/relay.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1252      +/-   ##
==========================================
+ Coverage   33.50%   34.84%   +1.34%     
==========================================
  Files         105      113       +8     
  Lines       15728    15995     +267     
==========================================
+ Hits         5270     5574     +304     
+ Misses       9415     9377      -38     
- Partials     1043     1044       +1     
Flag Coverage Δ
integration_tests 26.01% <0.00%> (-0.01%) ⬇️
integration_tests_byzantine 11.51% <0.00%> (-0.01%) ⬇️
integration_tests_gov 11.75% <0.00%> (-0.01%) ⬇️
integration_tests_grpc 11.75% <0.00%> (-0.01%) ⬇️
integration_tests_ibc 26.76% <33.33%> (+<0.01%) ⬆️
integration_tests_ledger 11.74% <0.00%> (-0.01%) ⬇️
integration_tests_slow 11.74% <0.00%> (-0.01%) ⬇️
integration_tests_solomachine 11.55% <0.00%> (-0.01%) ⬇️
integration_tests_upgrade 11.75% <0.00%> (-0.01%) ⬇️
unit_tests 8.72% <33.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songgaoye songgaoye force-pushed the song/nft-transfer-enforce-nft-port branch from 46020fa to 8bb655c Compare March 31, 2026 13:49
@github-actions github-actions bot added the ci label Apr 1, 2026
@songgaoye songgaoye marked this pull request as ready for review April 1, 2026 08:16
@songgaoye songgaoye requested a review from a team as a code owner April 1, 2026 08:16
@songgaoye songgaoye requested review from randy-cro and thomas-nguy and removed request for a team April 1, 2026 08:16
@songgaoye songgaoye added this pull request to the merge queue Apr 2, 2026
Merged via the queue into master with commit 3b87f0b Apr 2, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants