docs: fix typo and formatting in README and code comments#1238
Merged
songgaoye merged 2 commits intocrypto-org-chain:masterfrom Mar 17, 2026
Merged
docs: fix typo and formatting in README and code comments#1238songgaoye merged 2 commits intocrypto-org-chain:masterfrom
songgaoye merged 2 commits intocrypto-org-chain:masterfrom
Conversation
thomas-nguy
approved these changes
Mar 12, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1238 +/- ##
=======================================
Coverage 33.50% 33.50%
=======================================
Files 105 105
Lines 15728 15728
=======================================
Hits 5270 5270
Misses 9415 9415
Partials 1043 1043
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songgaoye
approved these changes
Mar 12, 2026
Contributor
|
@tsinglua please fix fmt. Thank you! index 449caa4..140f4ee 100644
--- a/x/nft-transfer/types/trace.go
+++ b/x/nft-transfer/types/trace.go
@@ -56,8 +56,8 @@ func IsAwayFromOrigin(sourcePort, sourceChannel, fullClassPath string) bool {
//
// Examples:
//
-// - "port-1/channel-1/class-1" => ClassTrace{Path: "port-1/channel-1", BaseClassId: "class-1"}
-// - "class-1" => ClassTrace{Path: "", BaseClassId: "class-1"}
+// - "port-1/channel-1/class-1" => ClassTrace{Path: "port-1/channel-1", BaseClassId: "class-1"}
+// - "class-1" => ClassTrace{Path: "", BaseClassId: "class-1"}
func ParseClassTrace(rawClassID string) ClassTrace {https://github.com/crypto-org-chain/chain-main/actions/runs/22944349905/job/66723146500?pr=1238 ci failed not related to this pr. will fix in pr #1239 |
Signed-off-by: tsinglua <tsinglua@outlook.com>
auto-merge was automatically disabled
March 12, 2026 02:39
Head branch was pushed to by a user without write access
Contributor
Author
@songgaoye Thanks. Modified. Please review it again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
This commit fixes minor documentation issues:
These changes improve documentation clarity and maintain consistent formatting standards.
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)