test(scorecard): scorecard test to verify Grafana data#900
Draft
tthvo wants to merge 10 commits intocryostatio:mainfrom
Draft
test(scorecard): scorecard test to verify Grafana data#900tthvo wants to merge 10 commits intocryostatio:mainfrom
tthvo wants to merge 10 commits intocryostatio:mainfrom
Conversation
tthvo
changed the title
tthvo
force-pushed
the
grafana-scorecard
branch
2 times, most recently
from
9f43ae6 to
984d7bb
Compare
tthvo
force-pushed
the
grafana-scorecard
branch
2 times, most recently
from
d098c44 to
8d85b79
Compare
|
This PR/issue depends on: |
tthvo
force-pushed
the
grafana-scorecard
branch
from
61ae9cc to
d71861f
Compare
Notes: Dockerfile needs updating to include the testdata directory.
tthvo
force-pushed
the
grafana-scorecard
branch
from
d71861f to
7a86ff2
Compare
Member
Author
|
Closing this because a lot has changed since and rebasing is not so fun. This can be a reference if anyone is interested :D |
Member
|
Reopning for visibility. I'll try to find time in the near-ish future to fix this up, or to remake it. |
Member
Author
|
Oh thanks! I realized that I left this for quite long. I can someday help review tho! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Fixes: #793
Depends on cryostatio/cryostat-grafana-dashboard#68
Description of the change:
WIP
Motivation for the change:
See #793
How to manually test:
WIP