Skip to content

fix: Vite 8 (Rolldown) compatibility for content scripts #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheldhur wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix: Vite 8 (Rolldown) compatibility for content scripts #1149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite-plugin/src/node/plugin-contentScripts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ export const pluginContentScripts: CrxPluginFn = () => {
}),
source: worldMainIds.has(script.id)
? createProMainLoader({
fileName: `./${fileName.split('/').at(-1)}`,
fileName: `../${fileName}`,
Copy link
Copy Markdown
Member

@Toumash Toumash May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure about the subdirectory why would it need a different behavior than a line below

 : createProLoader({ fileName }),

Copy link
Copy Markdown
Contributor Author

@sheldhur sheldhur May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just works this way. If you want to see something like createProMainLoader({ fileName }) I can change createProMainLoader

})
: createProLoader({ fileName }),
})
Expand Down
2 changes: 1 addition & 1 deletion packages/vite-plugin/src/node/plugin-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ export const pluginManifest: CrxPluginFn = () => {
const refId = this.emitFile({
type: 'chunk',
id,
name: basename(file),
name: file.replace(/[\\/]/g, '-'),
})
contentScripts.set(
file,
Expand Down
Loading