fix(traefik): handle comma-separated ClientHost in JSON logs#1665
Merged
LaurenceJJones merged 3 commits intocrowdsecurity:masterfrom Jan 29, 2026
Merged
Conversation
Fixes crowdsecurity#1589 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Use the last IP (the one that actually connected) rather than the first (which could be spoofed by an untrusted proxy). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1589
Description
If the connecting user is using a proxy like zscaler Traefik automatically appends the connecting IP as a CSV list of IP's since we dont trust the IP since its not our proxy, there nothing more we can do other than grab the last IP as that is the one that traefik saw. EG:
<x_forwarded_for_header>,<traefik_saw_this_one>note remediation components such as traefik might have a hard time knowing which IP to block but this is out of scope for hub
Checklist