Skip to content
This repository was archived by the owner on Jun 8, 2022. It is now read-only.

Workload Labeling Proposal#200

Draft
zzxwill wants to merge 4 commits intocrossplane:masterfrom
zzxwill:label
Draft

Workload Labeling Proposal#200
zzxwill wants to merge 4 commits intocrossplane:masterfrom
zzxwill:label

Conversation

@zzxwill
Copy link
Member

@zzxwill zzxwill commented Sep 7, 2020

to recommend a simple way - Workload Labeling, to easily
establish connections between Workloads, Components,
AppConfigurations, and pods.

Signed-off-by: Zheng Xi Zhou zzxwill@gmail.com

@zzxwill
Copy link
Member Author

zzxwill commented Sep 7, 2020

@wonderflow I doubt whether there is a more 'strict' way for an OAM user to set the label definition.oam.dev/unique-pod after checking the corresponding WorkloadDefinition, as I think he/she might forget the label.
Besides, the one who prepares WorkloadDefinition might not know the which label pod-template-hash/controller-revision-hash will be generated for the Pod by the workload.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we create a new field in workloadDefinition.spec instead of using a label.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WorkloadDefinition is created by Platform builder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like using OAM users here, it can't be understood clearly.

We general distinguish users by

  • Platform builder
  • Application Operator
  • Application Developer

@wonderflow
Copy link
Member

@wonderflow I doubt whether there is a more 'strict' way for an OAM user to set the label definition.oam.dev/unique-pod after checking the corresponding WorkloadDefinition, as I think he/she might forget the label.
Besides, the one who prepares WorkloadDefinition might not know the which label pod-template-hash/controller-revision-hash will be generated for the Pod by the workload.

What do you mean by saying OAM user here? If I understood you clearly, you may mean platform builder here? A platform builder won't forget anything if they are building service for their users.

wonderflow and others added 3 commits September 10, 2020 11:52
Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Signed-off-by: zzxwill <zzxwill@gmail.com>
* fix workload status for multiple revision case

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>

* add CurrentWorkingRevision flag in workload status

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Signed-off-by: zzxwill <zzxwill@gmail.com>
to recommend a simple way - Workload Labeling, to easily
establish connections between Workloads, Components,
AppConfigurations, and pods.

Signed-off-by: zzxwill <zzxwill@gmail.com>
@zzxwill zzxwill force-pushed the label branch 2 times, most recently from 2b9cf96 to 34cd4ee Compare September 10, 2020 03:53
update the design per the change of unique label crossplane#203
and address comments.

Signed-off-by: 天元 <jianbo.sjb@alibaba-inc.com>
Signed-off-by: zzxwill <zzxwill@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments