Forward unstable feature flags (-Z) to cargo metadata invocations#1517
Open
rnza0u wants to merge 1 commit intocross-rs:mainfrom
Open
Forward unstable feature flags (-Z) to cargo metadata invocations#1517rnza0u wants to merge 1 commit intocross-rs:mainfrom
rnza0u wants to merge 1 commit intocross-rs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
I ran across some issues when using nightly Cargo features such as
artifacts-dependencies.Cargo forces users to pass a
-Z bindepsflag to activate the feature in every cargo command.Cross already forwards the
+nightlyflag to internal cargo invocations, but it does not forward-Zflags.Consequently,
cargo metadataalways fail for projects using such feature.This problem would also occur when using other Cargo nightly features.
Solution
Parse the
-Zflags and forward them tocargo metadata.