Nested methods fix callstyles#99
Merged
noelwelsh merged 2 commits intocreativescala:developfrom May 15, 2025
Merged
Conversation
Contributor
|
Looks good to me! 👍 I don't think the outer brackets are strictly necessary but they do help indicate the logical structure of the expressions, which I think is useful to the reader. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reason for PR & what I did:
I noticed the nested methods page in fractals had a mixture of operator style and regular method style, so I unified them to the regular style we use through the book.
I checked the book still renders via
buildinsbtafter the changes.Files affected:
book/src/pages/fractals/nested-methods.md
Instructions for reviewers:
Are you happy with these changes? I'm confident in the changes on l.118 & l.144.
For ll.171, 176, 197 & 203, I've kept the outermost bracket - can you confirm this is still how it's done for the regular style?
I haven't tried to run the edited code snippets in an actual program, let me know if you'd like me to do this.
If you're happy with the changes, feel free to merge!
Thanks :)