fix: remove duplicate ValuePropExtensions; update TalkCmd.Play signature#5
Open
nafeger wants to merge 1 commit into
Open
fix: remove duplicate ValuePropExtensions; update TalkCmd.Play signature#5nafeger wants to merge 1 commit into
nafeger wants to merge 1 commit into
Conversation
…nature IsPoweredAttack, IsPoweredCardOrMonsterMoveBlock, and IsCardOrMonsterMove are now part of the native sts2 API. Keeping ModSmith's re-exports in the same namespace causes CS0121 ambiguity errors for any mod that references both assemblies. TalkCmd.Play signature changed from (LocString, Creature, double) to (LocString, Creature, VfxColor, VfxDuration) — updated CoinFlip template to match. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4
Summary
Sts2NativeExtensions.cs: RemovedIsPoweredAttack,IsPoweredCardOrMonsterMoveBlock, andIsCardOrMonsterMove— all three are now part of the nativests2API (MegaCrit.Sts2.Core.ValueProps.ValuePropExtensions). Having them defined in both assemblies under the same namespace causesCS0121ambiguity errors in any mod that uses them.CoinFlip.cs:TalkCmd.Playsignature changed from(LocString, Creature, double)to(LocString, Creature, VfxColor, VfxDuration). Updated both call sites to passVfxColor.Green/VfxColor.RedandVfxDuration.Standard.Root cause
The
Sts2NativeExtensions.csfile was added as a polyfill before these methods existed in the game. Now that the game exposes them natively at the same fully-qualified name and namespace, the C# compiler cannot resolve which assembly's definition to use — even with explicit static calls.Test plan
dotnet buildon a fresh mod generated from the template produces 0 errors🤖 Generated with Claude Code