Skip to content

ocl: ensure compatibility with LIBXSMM 2.0#672

Merged
hfp merged 1 commit intocp2k:developfrom
hfp:ocl
May 15, 2023
Merged

ocl: ensure compatibility with LIBXSMM 2.0#672
hfp merged 1 commit intocp2k:developfrom
hfp:ocl

Conversation

@hfp
Copy link
Copy Markdown
Member

@hfp hfp commented May 15, 2023

  • Updated LIBXSMM (Daint-CI).

@hfp
Copy link
Copy Markdown
Member Author

hfp commented May 15, 2023

CI is a concern as the CI or the code base is rapidly aging (maintenance). If we treat warnings as errors, the code base is not immune against newer compilers and dependencies (if newer compilers/dependencies are picked up by CI).

/opt/rocm-5.5.0/include/hipblas.h:16:2: error: #warning "This file is deprecated. Use the header file from /opt/rocm-5.5.0/include/hipblas/hipblas.h by using #include <hipblas/hipblas.h>" [-Werror=cpp]
   16 | #warning "This file is deprecated. Use the header file from /opt/rocm-5.5.0/include/hipblas/hipblas.h by using #include <hipblas/hipblas.h>"
      |  ^~~~~~~
cc1plus: all warnings being treated as errors

... which means, ROCm builds are now failing for reasons unrelated to contributions or this PR.

@dev-zero
Copy link
Copy Markdown
Contributor

@hfp yes, software needs constant upkeep. Todays warnings are tomorrows errors.
We could pin versions, but then we let our users discover the errors.
For pre-commit configuration and Python deps, the dependabot approach is nice, will do periodic scans for new versions and create PRs to pull. Allowing a stable CI env and making sure deps get updated periodically.

@hfp
Copy link
Copy Markdown
Member Author

hfp commented May 15, 2023

@hfp yes, software needs constant upkeep. Todays warnings are tomorrows errors. We could pin versions, but then we let our users discover the errors. For pre-commit configuration and Python deps, the dependabot approach is nice, will do periodic scans for new versions and create PRs to pull. Allowing a stable CI env and making sure deps get updated periodically.

Thanks! Btw, #650 looks good, and I will let this PR wait for it.

@dev-zero
Copy link
Copy Markdown
Contributor

merged the fixes (with a separate PR)

* Updated LIBXSMM (Daint-CI).
@hfp hfp merged commit fdba3c2 into cp2k:develop May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants