Open
Conversation
danimoh
added a commit
to danimoh/jsQR
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I really like this project, thanks for sharing it with people!
One small note: it is bit of a pain using the demo as it is now.
The usability can be improved by constantly showing the already decoded texts.
It changes the "demo" into a fully operational tool, in my opinion. (For me, who do not want to share data with a server.)
Note that the implementation is now ugly, it only demonstrates the idea.
However, I am open to suggestions to how to solve this in a more elegant way.