[feat][trace] support trace table sharding by workspace - #636
Open
cuichen01 wants to merge 3 commits into
Open
Conversation
- Add SupportShard/ShardList to TableCfg for per-TTL shard configuration - Add TenantShardConfig type and GetTenantShardConfig interface method - Read path: expand shard tables in getQueryTenantTables (full double-read) - Write path: route InsertSpans/InsertAnnotations to correct shard by workspace - Group exporter writes by (TTL, WorkspaceID) pair
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (45.45%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #636 +/- ##
=======================================
Coverage ? 78.41%
=======================================
Files ? 694
Lines ? 85522
Branches ? 0
=======================================
Hits ? 67065
Misses ? 14529
Partials ? 3928
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Eliminate separate tenant_shard_config TCC key. Space-to-shard mapping now lives in TableCfg.ShardConfig alongside the table definition, reducing config lookups and simplifying the architecture.
Enable downstream implementations to perform shard-aware table filtering based on query time range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Check the PR title
(Optional) Translate the PR title into Chinese
(Optional) More detailed description for this PR(en: English/zh: Chinese)
en:
zh(optional):
(Optional) Which issue(s) this PR fixes