fix(token-info): Reduce token-info metadata fetch fan out.#4420
Open
metalurgical wants to merge 3 commits into
Open
fix(token-info): Reduce token-info metadata fetch fan out.#4420metalurgical wants to merge 3 commits into
metalurgical wants to merge 3 commits into
Conversation
Replace unbounded token-info join_all fan-out with bounded buffer_unordered concurrency to avoid excessive calls for large token sets.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces join_all with a buffered stream approach in TokenInfoFetcher and CachedTokenInfoFetcher to limit concurrent token info requests to a maximum of 20. Feedback suggests deduplicating the input address list using a HashSet in both fetchers to prevent redundant processing and unnecessary RPC calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce token-info metadata fetch fan out.
Changes
join_alltoken-info fetching withbuffer_unorderedHow to test
cargo nextest run