Remove unconditional OrderCreation clone in post_order_handler#4410
Draft
ashleychandy wants to merge 1 commit into
Draft
Remove unconditional OrderCreation clone in post_order_handler#4410ashleychandy wants to merge 1 commit into
ashleychandy wants to merge 1 commit into
Conversation
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates the
order.clone()call inpost_order_handlerby extracting a subset of fieldsbefore consuming the order into
add_order.Opening as draft not confident the current field subset provides sufficient debugging context
on failure. Looking for input before marking ready.
Changes
.map(...).inspect_err(...).into_response()flow with an explicitmatchCopyfields before movingorderintoadd_order:from,sell_token,buy_token,kind,sell_amount,buy_amountOrderCreationstructorder.clone()