surplus and fee calculations into reusable methods#4405
Open
ashleychandy wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors trade metric calculations to support single-pass computation using pre-computed surplus values. It introduces the calculate_all_metrics method and several helper functions in the math module to derive ETH-denominated surplus and fees. No critical issues found; I have no feedback to provide.
|
This pull request has been marked as stale because it has been inactive a while. Please update this pull request or it will be automatically closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimizes trade metric calculations by computing surplus once and reusing it, eliminating redundant calculations when surplus, fees, and breakdown are needed together.
Changes
calculate_all_metrics()for single-pass calculation of surplus, fee, and breakdownsurplus_to_ether(),fee_to_ether(),protocol_fees_from_surplus(),fee_breakdown_from_surplus())TradeMetricsstruct to hold all metrics together