Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 27 28 +1
Lines 1123 1130 +7
=======================================
+ Hits 1122 1129 +7
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Fix IFT mint/finalize_transfer account layouts for split app_state/app_mint_state - Add missing accounts to chunk uploads and recv_packet - Update e2e test for new IFT API signatures
- Add Test_Deploy smoke test for chain and contract readiness - Add timeout tests for both Eth→Solana and Solana→Eth directions - Add error ack test for failed receive on Ethereum - Enhance roundtrip test with pending transfer and packet commitment verification - Restructure roundtrip with nested s.Run blocks matching other e2e suites - Extract adminMintIFTTokens helper to reduce duplication
mariuszzak
reviewed
Feb 24, 2026
| init_if_needed, | ||
| payer = payer, | ||
| space = 8 + SolanaPayloadHint::INIT_SPACE, | ||
| seeds = [SolanaPayloadHint::SEED, payer.key().as_ref()], |
Collaborator
There was a problem hiding this comment.
Should we add packet identifiers to the seeds (client_id, sequence)?
mariuszzak
reviewed
Feb 24, 2026
| .remaining_accounts | ||
| .get(HINT_ACCOUNT_INDEX) | ||
| .ok_or(GMPError::InsufficientAccounts)?; | ||
|
|
Collaborator
There was a problem hiding this comment.
We could close the hint account after reading it.
- Inject attestation proofs into timeout messages via solana_attested - Pass timeout_relay_height from caller to ensure proof height has a consensus timestamp past the packet's timeout - Extract duplicated update_client logic into shared solana_attested.rs behind SolanaAttestationTxBuilder trait
Collaborator
|
The hint content is not validated against the IBC payload - a malicious relayer can substitute the receiver in instruction data and redirect minted tokens. Two alternatives that fix this by committing execution data in the IBC packet:
|
Collaborator
|
Opened a follow-up PR based on this branch with an alternative solution: #959 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.