Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #623 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 17 17
Lines 767 767
=======================================
Hits 766 766
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
srdtrk
reviewed
Jul 31, 2025
Member
srdtrk
left a comment
srdtrk
left a comment
There was a problem hiding this comment.
I added some questions and suggestions
| @@ -1,5 +1,5 @@ | |||
| # Which type of ethereum testnet to run locally (pow|pos) | |||
| ETH_TESTNET_TYPE="pow" | |||
| ETH_TESTNET_TYPE="pos" | |||
Member
There was a problem hiding this comment.
I think I'd prefer pow for the example file. I usually run pow if I don't have to run pos
| # Either an empty string, or 'local', means it will use the local binary in the repo, unless running in mock mode | ||
| # Otherwise, it will download the binary from the release at the specified tag | ||
| E2E_WASM_LIGHT_CLIENT_TAG="cw-ics08-wasm-eth-vX.Y.Z" | ||
| E2E_WASM_LIGHT_CLIENT_TAG="local" |
Member
There was a problem hiding this comment.
In this case, cw-ics08-wasm-eth-vX.Y.Z format should be mentioned in the comments above
| E2E_WASM_LIGHT_CLIENT_TAG="local" | ||
|
|
||
| # URL of the Tendermint RPC node for SP1 fixture generation | ||
| # URL of the Tendermint RPC node |
Member
There was a problem hiding this comment.
I don't think this env var is used elsewhere at the moment. So isn't true that it is used for SP1 fixture generation?
Comment on lines
+30
to
+32
| # URL of the Ethereum RPC node | ||
| # use https://ethereum-sepolia.publicnode.com/ for the Eth Sepolia testnet | ||
| RPC_URL=https://ethereum-holesky-rpc.publicnode.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.