Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 15 15
Lines 744 744
=======================================
Hits 743 743
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjermundgaraba
changed the title
gjermundgaraba
changed the title
|
Looks like things are much more stable now: https://github.com/cosmos/solidity-ibc-eureka/actions/runs/13965649544 |
| func retryConfig() grpc.DialOption { | ||
| policy := `{ | ||
| "methodConfig": [{ | ||
| "name": [{}], | ||
| "retryPolicy": { | ||
| "MaxAttempts": 4, | ||
| "InitialBackoff": ".01s", | ||
| "MaxBackoff": ".01s", | ||
| "BackoffMultiplier": 1.0, | ||
| "RetryableStatusCodes": [ | ||
| "CANCELLED", | ||
| "UNKNOWN", | ||
| "DEADLINE_EXCEEDED", | ||
| "NOT_FOUND", | ||
| "ALREADY_EXISTS", | ||
| "PERMISSION_DENIED", | ||
| "RESOURCE_EXHAUSTED", | ||
| "FAILED_PRECONDITION", | ||
| "ABORTED", | ||
| "OUT_OF_RANGE", | ||
| "UNIMPLEMENTED", | ||
| "INTERNAL", | ||
| "UNAVAILABLE", | ||
| "DATA_LOSS", | ||
| "UNAUTHENTICATED" | ||
| ] | ||
| } | ||
| }] | ||
| }` | ||
|
|
||
| return grpc.WithDefaultServiceConfig(policy) |
There was a problem hiding this comment.
Is it not possible to create this in a type safe way or with a builder. (Not that I think we should build one, but asking if grpc already has a builder or something similar)
There was a problem hiding this comment.
Hmm, good question. I'll check!
There was a problem hiding this comment.
Doesn't seem like this exists in the go version of the library :/
| func (e Ethereum) ForgeScript(deployer *ecdsa.PrivateKey, solidityContract string, args ...string) ([]byte, error) { | ||
| args = append(args, "script", "--rpc-url", e.RPC, "--private-key", | ||
| hex.EncodeToString(deployer.D.Bytes()), "--broadcast", | ||
| hex.EncodeToString(crypto.FromECDSA(deployer)), "--broadcast", |
There was a problem hiding this comment.
Interesting, curious if you know why it was less stable before
There was a problem hiding this comment.
Not 100%, but there is a different handling of the private key bytes (something about fixed sized buffers and whatnot). But this seems to be the correct way, at least.
2 participants
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.