fix: investigate gogo Clone() method issue#26225
Draft
SillyZir wants to merge 1 commit intocosmos:mainfrom
Draft
fix: investigate gogo Clone() method issue#26225SillyZir wants to merge 1 commit intocosmos:mainfrom
SillyZir wants to merge 1 commit intocosmos:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exclude gogoproto-generated
Clone()files from code coverage to prevent false coverage drops caused by auto-generated clone methods that triggerpanic: merger not found for type:big.Wordduring v50-v53 upgrades.Fixes #25843
Problem
Upgrades from v50 to v53 introduced a panic in gogoproto's
Clone()method (panic: merger not found for type:big.Word), and the generated clone files were incorrectly included in coverage reports, skewing coverage metrics and masking the real issue.Solution
Added
"**/*clone*.go"to theignorelist incodecov.yml, ensuring all gogoproto-generated clone files are excluded from coverage analysis. The existing ignore entries were shifted down to accommodate the new pattern at the appropriate position in the list.Impact
Coverage reports now accurately reflect meaningful, hand-written code rather than being polluted by auto-generated clone methods. This eliminates noisy coverage diffs on PRs touching protobuf definitions and aligns coverage configuration with the actual source of the
Clone()panic tracked in #25843.