fix: pass speed and emotion params through tts() and tts_to_file()#4414
Open
ivanVgusev wants to merge 2 commits intocoqui-ai:devfrom
Open
fix: pass speed and emotion params through tts() and tts_to_file()#4414ivanVgusev wants to merge 2 commits intocoqui-ai:devfrom
ivanVgusev wants to merge 2 commits intocoqui-ai:devfrom
Conversation
speed passed to tts_to_file() and tts() was silently consumed and never forwarded to the underlying model. Xtts.inference() supports speed natively, but the parameter was dropped in the API layer before reaching synthesizer.tts(). - tts_to_file(): pass emotion and speed to self.tts() - tts(): pass speed to self.synthesizer.tts() - Update docstrings: speed works with XTTS v2, not only Coqui Studio models
|
ivanVgusev seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Contributor
|
You can use our fork (available via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
speedpassed totts_to_file()andtts()was silently consumed and neverforwarded to the underlying model. As a
result:
had no effect on XTTS v2, even though
Xtts.inference()fully supportsspeed.Root cause
tts_to_file()did not passspeed/emotiontoself.tts()tts()did not passspeedtoself.synthesizer.tts()synthesizer.tts()forwards**kwargs→Xtts.synthesize()→inference(),so the fix only required two missing
arguments in the API layer.
Changes
tts(): addspeed=speedtosynthesizer.tts()calltts_to_file(): addspeed=speed, emotion=emotiontoself.tts()callspeedworks withXTTS v2, not only Coqui Studio models