[codex] Improve service conflict suggestions - #224
Draft
Jonesxq wants to merge 1 commit into
Draft
Conversation
Closes: containers#212 Signed-off-by: jones <239089032+Jonesxq@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-services-checkreplaces the conflicting service file and include its pathWhy
The previous suggestion always recommended both
--fileand--name, even when only one option applied. It also described--skip-services-checkas acceptable without explaining which existing service file would be replaced. This made conflicts confusing when the output path itself was not the source of the conflict.Validation
cargo fmt --verbose --checkcargo test --verbose(79 tests passed)cargo clippy -- -Dwarningson Linuxgit diff --checkCloses #212