feat: add make target to install claude-agent-acp#949
Open
Deepak8858 wants to merge 1 commit intocontainers:mainfrom
Open
feat: add make target to install claude-agent-acp#949Deepak8858 wants to merge 1 commit intocontainers:mainfrom
Deepak8858 wants to merge 1 commit intocontainers:mainfrom
Conversation
Cali0707
reviewed
Mar 24, 2026
| set -e ;\ | ||
| echo "Installing claude-agent-acp $(CLAUDE_AGENT_ACP_VERSION) to $(CLAUDE_AGENT_ACP)..." ;\ | ||
| mkdir -p $(shell dirname $(CLAUDE_AGENT_ACP)) ;\ | ||
| GOBIN=$(shell dirname $(CLAUDE_AGENT_ACP)) go install github.com/mcpchecker/claude-agent-acp/cmd/claude-agent-acp@$(CLAUDE_AGENT_ACP_VERSION) ;\ |
Collaborator
There was a problem hiding this comment.
This is not the correct claude-agent-acp (and also does not exist).
The real one is here: https://github.com/zed-industries/claude-agent-acp
In the future, if you are using an LLM to help contribute I would recommend double checking the output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
mcpcheckertarget to also install theclaude-agent-acpbinary, which is required for some evaluation flows.Fixes #947