.github: update to golangci-lint v2#1166
Open
squeed wants to merge 2 commits intocontainernetworking:mainfrom
Open
.github: update to golangci-lint v2#1166squeed wants to merge 2 commits intocontainernetworking:mainfrom
squeed wants to merge 2 commits intocontainernetworking:mainfrom
Conversation
Member
squeed
commented
Jul 21, 2025
squeed
commented
- change config file
- bump action and lint version
- fix minor issues found.
Some more issues picked up by a new version of golangci-lint. Signed-off-by: Casey Callendrello <c1@caseyc.net>
- change config file - bump action and lint version Signed-off-by: Casey Callendrello <c1@caseyc.net>
mmorel-35
requested changes
Jul 21, 2025
| @@ -1,30 +1,40 @@ | |||
| version: "2" | |||
| linters: | |||
| enable: | |||
Contributor
There was a problem hiding this comment.
Keep the list of used linter visible, only typecheck and maybe ineffassign are not available anymore here. Appart form gofumpt and gci as they are now in formatter section
Member
Author
There was a problem hiding this comment.
i just did golangci-lint migrate and this is exactly what it spit out. I'll take a closer look.
Contributor
There was a problem hiding this comment.
That's exactly why I point it 😉. The migrate tool is noisy on that part
Comment on lines
+21
to
+24
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
Contributor
There was a problem hiding this comment.
Remove this part as there are no path matching those in the project
Comment on lines
+37
to
+40
| paths: | ||
| - third_party$ | ||
| - builtin$ | ||
| - examples$ |
Contributor
There was a problem hiding this comment.
Remove this part as there are no path matching those in the project
mmorel-35
reviewed
Jul 21, 2025
| config_file: .yamllint.yaml | ||
|
|
||
| - uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0 | ||
| - uses: golangci/golangci-lint-action@v8 |
Contributor
There was a problem hiding this comment.
Suggested change
| - uses: golangci/golangci-lint-action@v8 | |
| - uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.