Add support for gRPC client protocol #80
Open
+985
−293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anuraag Agrawal <[email protected]>
anuraaga
commented
Jan 12, 2026
| # Need to use async APIs for proper cancellation support in Python. | ||
| # Bidirectional streaming not supported | ||
| "--skip", | ||
| "**/full-duplex/**", |
Collaborator
Author
There was a problem hiding this comment.
My conformance test implementation for full-duplex was wrong, allowing httpx to pass it. I fixed it and now httpx correctly fails it for not supporting bidirectional streaming
| "--skip", | ||
| "**/full-duplex/**", | ||
| # Cancellation delivery isn't reliable | ||
| "--known-flaky", |
Collaborator
Author
There was a problem hiding this comment.
The new client seems to perform just fine for cancellation and timeouts so far. This does reduce my motivation to chase the issue in httpx upstream.
Given it also enables bidirectional streaming, I guess we'll need to consider whether pyqwest should be the default client, but being so new definitely nervous about it, happy to hear any thoughts
| from google.protobuf.message import Message | ||
| from pyqwest import HTTPTransport, SyncHTTPTransport | ||
| from pyqwest import HTTPVersion as PyQwestHTTPVersion | ||
| from pyqwest.httpx import AsyncPyqwestTransport, PyqwestTransport |
Collaborator
Author
There was a problem hiding this comment.
For now, just slots in using this httpx-compatible wrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on pyqwest an HTTP client I released that supports bidirectional streaming and trailers. The approach is similar to server side, moving some pieces into a
ClientProtocolabstraction and writing gRPC versions.#49