Open
Conversation
conda-bot
added
the
cla-signed
2 tasks
Rogdham
reviewed
Dec 29, 2025
| # In one test reusing the context saves difference between .006s and .01s | ||
| # We could make this a threadlocal. | ||
| dctx = zstandard.ZstdDecompressor() | ||
| dctx = ZstdDecompressor() |
There was a problem hiding this comment.
I would suggest using the decompress function directly instead of creating dctx = ZstdDecompressor() first:
dctxcannot be re-used- If the compressed data is composed of several Zstandard frames, you will only decompress the first one
Contributor
Author
There was a problem hiding this comment.
I see. Different than the other zstandard library.
| """ | ||
| cache = cache.copy() | ||
| dctx = zstandard.ZstdDecompressor(max_window_size=ZSTD_MAX_SHARD_SIZE) | ||
| dctx = ZstdDecompressor() |
jaimergp
reviewed
Feb 5, 2026
| --file tests\requirements-s3.txt | ||
| --file ..\conda-libmamba-solver\dev\requirements.txt | ||
| ${{ matrix.test-type == 'conda-libmamba-solver' && '--file ..\\conda-libmamba-solver\\tests\\requirements.txt' || '' }} | ||
| ${{ matrix.python-version < '3.14' && 'backports.zstd' || '' }} |
Contributor
There was a problem hiding this comment.
Suggested change
| ${{ matrix.python-version < '3.14' && 'backports.zstd' || '' }} | |
| ${{ matrix.python-version < '3.14' && 'backports.zstd' || '' }} |
Hm, are we relying of lexicographical sorting for this comparison? I guess since the lower bound is 3.10 anyway we don't have issues with 3.9 > 3.14. Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This library also does not require max_output_size when decompressing data without a zstandard size header.
Fix #811
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?