Skip to content

Conversation

@candleindark
Copy link
Contributor

@candleindark candleindark commented Jan 23, 2026

This PR closes #304

@candleindark candleindark marked this pull request as ready for review January 23, 2026 19:12
Copilot AI review requested due to automatic review settings January 23, 2026 19:12
@candleindark candleindark added the semver-patch Increment the patch version when merged label Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces the datetime_filesafe format field with datetime in the output file prefix format string throughout the codebase. The change maintains backwards compatibility by still accepting datetime_filesafe in the LogPaths.create() method while promoting datetime as the new standard. The actual datetime format remains unchanged (still file-safe: %Y.%m.%dT%H.%M.%S).

Changes:

  • Updated default DUCT_OUTPUT_PREFIX to use {datetime} instead of {datetime_filesafe}
  • Modified LogPaths.create() to support both {datetime} and {datetime_filesafe} format fields for backwards compatibility
  • Updated documentation in CLI help text and README to reflect the new {datetime} field name

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
src/con_duct/duct_main.py Updated default prefix constant and modified LogPaths.create() to accept both datetime and deprecated datetime_filesafe fields
src/con_duct/cli.py Updated CLI help text to remove reference to datetime_filesafe and show only datetime as a supported format field
README.md Updated documentation examples and help text to use {datetime} instead of {datetime_filesafe}
test/duct_main/test_log_paths.py Updated test to use new {datetime} format field instead of {datetime_filesafe}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@candleindark candleindark force-pushed the datetime-format-field branch 2 times, most recently from 8c04811 to b2e52bc Compare January 23, 2026 19:22
@candleindark candleindark force-pushed the datetime-format-field branch from b2e52bc to ebe4aac Compare January 23, 2026 19:22
@candleindark candleindark marked this pull request as draft January 23, 2026 19:23
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.19%. Comparing base (f35633e) to head (ebe4aac).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
- Coverage   91.38%   91.19%   -0.19%     
==========================================
  Files           8        8              
  Lines        1056     1056              
  Branches      138      138              
==========================================
- Hits          965      963       -2     
- Misses         69       70       +1     
- Partials       22       23       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@candleindark candleindark marked this pull request as ready for review January 23, 2026 19:40
@candleindark candleindark requested a review from asmacdo January 23, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deprecate {datetime_filesafe} and prefer {datetime} for output prefix

1 participant