Fix LIMIT 0 not being transformed to algebra - #175
Merged
Conversation
jitsedesmet
requested changes
Aug 10, 2026
jitsedesmet
left a comment
jitsedesmet
left a comment
Member
There was a problem hiding this comment.
Thank you for the README. Few questions.
Contributor
Author
|
There seems to be an issue with the generator for the canonical files. |
Contributor
Author
|
Fixed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LIMIT 0was not transformed to algebra because 0 would make the condition be falsy.Also added a packages/test-utils/statics/algebra/README.md that explains how you're supposed to add new tests.
This fixes part of comunica/comunica#1736.