catch AttrbuteError on typing imports from ironpython#1454
catch AttrbuteError on typing imports from ironpython#1454chenkasirer wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
- Coverage 61.87% 61.86% -0.02%
==========================================
Files 208 208
Lines 22329 22329
==========================================
- Hits 13817 13813 -4
- Misses 8512 8516 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
are we still certain this change is needed and that the error was not triggered by something else? |
|
I have only a partial idea why this happened: I had a No idea how it got there - I had it locally and at one point in time it was also found on CI. so import in COMPAS for The interesting part is that The only mention I could find of this is this issue which doesn't offer a lot of explanations: Anyways, this has no longer been an issue on CI for me, and locally I just re-installed IPY and module was gone. So I'll go ahead and close this. |
Not sure what has changed because these imports aren't new, but started getting
AttributeErroron these typing imports from ironpython.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.