Skip to content

Improves adguardhome-sync addon when running on alpine LXCs#12362

Merged
CrazyWolf13 merged 2 commits intocommunity-scripts:mainfrom
Darkangeel-hd:patch-1
Feb 26, 2026
Merged

Improves adguardhome-sync addon when running on alpine LXCs#12362
CrazyWolf13 merged 2 commits intocommunity-scripts:mainfrom
Darkangeel-hd:patch-1

Conversation

@Darkangeel-hd
Copy link
Copy Markdown
Contributor

✍️ Description

Improves the adguardhome-sync addon script usage on clean alpine LXC, not created thought community scripts.
Installs required jq dependency if not found, otherwise the script fails.
The old function used to get the container ip address doesn't work with alpines busybox utils, so it was rewritten.

🔗 Related Issue

Fixes #12337

✅ Prerequisites

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

Better handle edge case of `curl` not being installed on Alpine.
Install `jq`, required by `fetch_and_deploy_gh_release()`, which if not installed makes the script error out with confusing stuff
Rewritten `get_ip()` to make it also work on busybox environments (Alpine).
`jq` is installed by some code inside of `fetch_and_deploy_gh_release` for debian
So it doesn't make much sense to install it here.
We only do so for alpine, as if its not installed it breaks the script
@CrazyWolf13 CrazyWolf13 merged commit c0fde54 into community-scripts:main Feb 26, 2026
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adguardhome-sync script not working as expected

3 participants