Fix: Hide "Edit Image" button for unsupported non-JPEG files#6653
Open
Kota-Jagadeesh wants to merge 1 commit intocommons-app:mainfrom
Open
Fix: Hide "Edit Image" button for unsupported non-JPEG files#6653Kota-Jagadeesh wants to merge 1 commit intocommons-app:mainfrom
Kota-Jagadeesh wants to merge 1 commit intocommons-app:mainfrom
Conversation
|
✅ Generated APK variants! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #6642 (comment)
What changes did you make and why?
UploadMediaDetailFragmentto verify if the uploaded image is a JPEG.llEditImage.visibility = View.GONE) for non-JPEG formats like GIF, PNG, and WEBP.LLJTran) only supports lossless JPEG transformations. Attempting to edit and save other file types resulted in errors and blank images. so, hiding the edit option for unsupported files is the cleanest ux solution.Tests performed (required)
Tested ProDebug on Redmi Note 13 Pro with API level 35.
.jpgfile -> "Edit Image" button is visible and works..gifand.pngfile -> "Edit Image" button is completely hidden.Screenshots (for UI changes only)
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.