Shorten id of WorkflowStepInput via graph_split.py#54
Shorten id of WorkflowStepInput via graph_split.py#54altairwei wants to merge 2 commits intocommon-workflow-language:mainfrom
Conversation
mr-c
left a comment
There was a problem hiding this comment.
Thank you for this PR! Can you add a test case to confirm your change?
I can give it a try. But |
Even a single test case would be nice |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 23.82% 23.87% +0.05%
==========================================
Files 14 14
Lines 19277 19299 +22
==========================================
+ Hits 4593 4608 +15
- Misses 14684 14691 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I am used to using VSCode to write CWL documents and use Benten as a CWL Language Server to provide error checking for the editor. However, when I split the packed document using
graph_split, I found that Benten was hinting that the id in my WorkflowStepInput was incorrect and that its id name contained an unnecessary prefix. Although I usedcwltool --validto validate the CWL document and found no problem, I wanted to correct the error that Benten was prompting, which is why I created this pull request.