COMDOX-1671: Removed all references to ProductDetails except the deprecation notice#888
Open
bdenham wants to merge 7 commits into
Open
COMDOX-1671: Removed all references to ProductDetails except the deprecation notice#888bdenham wants to merge 7 commits into
bdenham wants to merge 7 commits into
Conversation
sirugh
requested changes
May 15, 2026
Contributor
sirugh
left a comment
sirugh
left a comment
There was a problem hiding this comment.
This is really good, but we need to talk about whether it's better to remove entirely, or retain but with deprecated label.
Comment on lines
+24
to
+29
| <Aside type="caution"> | ||
| The monolithic `ProductDetails` container is deprecated. It is not used in the Commerce boilerplate. Do not use it for new work. Compose the smaller containers in this table instead (for example, [ProductHeader](/dropins/product-details/containers/product-header/), [ProductGallery](/dropins/product-details/containers/product-gallery/), [ProductPrice](/dropins/product-details/containers/product-price/), and [ProductOptions](/dropins/product-details/containers/product-options/)), then use [Slots](/dropins/product-details/slots/) on each container when you need slot-based customization. | ||
| </Aside> | ||
|
|
||
| Add to Cart, Add to Wishlist, and similar primary actions are not provided through the Product Details slots in the [Slots](/dropins/product-details/slots/) table. The storefront composes them in the product-details block using separate mount points and the Wishlist or cart patterns described in [Add to Cart and Add to Wishlist](/dropins/product-details/slots/#add-to-cart-and-add-to-wishlist) on that page. | ||
|
|
| | Container | Slots | | ||
| |-----------|-------| | ||
| | [`ProductAttributes`](#productattributes-slots) | `Attributes` | | ||
| | [`ProductDetails`](#productdetails-slots) | `Title`, `SKU`, `RegularPrice`, `SpecialPrice`, `Options`, `Quantity`, `Actions`, `ShortDescription`, `Description`, `Attributes`, `Breadcrumbs`, `GalleryContent`, `InfoContent`, `Content` | |
Contributor
There was a problem hiding this comment.
Same, I'd re-add this with clear indication that it is deprecated, like in the Container column of this table it was removed from. Or even a new column, Deprecated that has boolean entries?.
| } | ||
| })(block); | ||
| ``` | ||
| Slots for the deprecated monolithic single-container API are not documented on this page, and that pattern is not used in the Commerce boilerplate. For the full container list, links to each topic, and the canonical deprecation notice, use the [containers overview](/dropins/product-details/containers/). For migration context, see [Product details page architectural evolution](/boilerplate/updates/#product-details-page-architectural-evolution). |
Contributor
There was a problem hiding this comment.
Would have to change this if we decide to keep the deprecated API.
Co-authored-by: Stephen <sirugh@users.noreply.github.com>
sirugh
reviewed
May 15, 2026
| ``` | ||
|
|
||
| ## ProductDetails slots | ||
| ## ProductDetails slots (deprecated) |
Contributor
There was a problem hiding this comment.
Nit: The slots aren't deprecated, the container is. Can we tune this slightly on the entire PR? I noticed it's a bit backwards (to me at least)
Good:
ProductDetails Container (deprecated)
ProductDetails (deprecated) slots
Bad:
ProductDetails (deprecated) container
ProductDetails slots (deprecated)
sirugh
reviewed
May 18, 2026
| import { ProductDetails } from '@dropins/storefront-pdp/containers/ProductDetails.js'; // (deprecated) | ||
|
|
||
| // New: Multiple independent containers | ||
| // After: multiple independent containers |
Contributor
There was a problem hiding this comment.
"Old" vs "New"
"Before" vs "After"
See line 373. Pick one :)
sirugh
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request (PR) deprecates and removes public documentation for the monolithic Product Details
ProductDetailscontainer while keeping a single canonical deprecation on the containers overview and in enrichments. It updates PDP migration copy, slots, prerender examples, sidebar.Preview
https://commerce-docs.github.io/microsite-commerce-storefront/dropins/product-details/containers/product-details/
Associated JIRA ticket
COMDOX-1671
Affected pages