fix backup GPT partition entries offset to respect UEFI minimum array size#128
Open
andiradulescu wants to merge 1 commit intocommaai:masterfrom
Open
fix backup GPT partition entries offset to respect UEFI minimum array size#128andiradulescu wants to merge 1 commit intocommaai:masterfrom
andiradulescu wants to merge 1 commit intocommaai:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
[gpt] Partition entries CRC32 mismatchwarnings seen afterrepairGpt.asAlternate()computed the backuppartEntriesStartLbausing only the actual entry count (e.g. 64 entries = 2 sectors at 4096-byte sectors), but the UEFI spec and Qualcomm'sfixgptboth reserve a minimum of 16,384 bytes (4 sectors). This placed the backup entries at the wrong offset, causing a stalepartEntriesCrc32in the backup header.GPT images only contain the primary table.
repairGptcreates the backup viaasAlternate(), which now usesMath.max(numPartEntries * partEntrySize, 16384)to respect the UEFI minimum, matching ABL'sMIN_PARTITION_ARRAY_SIZE = 0x4000.Test plan
repairgpton LUN 4 (64 entries), verified no CRC mismatch viagetactiveslotbun testpassesbun lintpasses