Hyundai CAN Longitudinal: Enable for Camera SCC cars#1107
Closed
sunnyhaibin wants to merge 15 commits intocommaai:masterfrom
Closed
Hyundai CAN Longitudinal: Enable for Camera SCC cars#1107sunnyhaibin wants to merge 15 commits intocommaai:masterfrom
sunnyhaibin wants to merge 15 commits intocommaai:masterfrom
Conversation
Contributor
|
Can you write a test case for these in tests/safety/test_hyundai.py? |
Contributor
Author
I could attempt it in the next coming days. |
sunnyhaibin
force-pushed
the
camera-scc-long
branch
from
cd0400e to
d78cae7
Compare
sunnyhaibin
force-pushed
the
camera-scc-long
branch
from
4dcde30 to
a26093a
Compare
Contributor
Author
Unite test updated and all passed. |
sunnyhaibin
changed the title
This was referenced Dec 7, 2024
# Conflicts: # board/safety/safety_hyundai.h
sshane
reviewed
Jan 15, 2025
Co-authored-by: Shane Smiskol <shane@smiskol.com>
Contributor
Author
|
@sshane @adeebshihadeh anything still required for this PR to merge before 0.9.8 release? We have the changes in opendbc merged and bumped in openpilot, but users are unable to use openpilot longitudinal due to SCC messages not blocked on bus 2 (from this PR): |
Contributor
|
We've moved the car safety code into opendbc, please rebase and re-open your PR there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openpilot longitudinal control support for CAN-based HKG cars that have the following messages send from the car on bus 2:
SCC11SCC12SCC13SCC14FCA11FCA12Currently with 2022 Hyundai Kona EV, without radar disable. As the messages send from the car on bus 2, we block the messages and send our own longitudinal commands to bus 0.
FCA11andFCA12do stock FCW and AEB, and are forwarded from the LKAS camera to the car.Prerequisite of
Related
Thanks to community Kona EV 2022 owner Zack1010OP.