car tests: cache CANDefine values and speed KF gain#3212
Open
javery556 wants to merge 1 commit intocommaai:masterfrom
Open
car tests: cache CANDefine values and speed KF gain#3212javery556 wants to merge 1 commit intocommaai:masterfrom
javery556 wants to merge 1 commit intocommaai:masterfrom
Conversation
Contributor
Car behavior reportReplays driving segments through this PR and compares the behavior to master. ✅ No changes detected |
Contributor
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs commaai/openpilot#32536
Summary
CANDefinevalues per DBC so car state init does not rebuild the same enum maps for every Hypothesis exampleCarStateBaseinstead of solving it again on each initializationValidation
Test plan
pytest selfdrive/car/tests/test_car_interfaces.py --durations=20 -q241 passed in 7.77s241 passed in 6.42spytest selfdrive/car/tests/test_car_interfaces.py -n0 --durations=20 -q241 passed in 46.94s0.94s0.195spytest selfdrive/car/tests/test_car_interfaces.py -n0 -k 'FORD_FOCUS_MK4 or MAZDA_CX9_2021 or SKODA_FABIA_MK4' --durations=10 -qFORD_FOCUS_MK4:0.19sMAZDA_CX9_2021:0.15sSKODA_FABIA_MK4:0.17s