perf: gate devtools in prod and lazy-load leaflet to reduce initial js#603
Open
cc-cruz wants to merge 1 commit intocommaai:masterfrom
Open
perf: gate devtools in prod and lazy-load leaflet to reduce initial js#603cc-cruz wants to merge 1 commit intocommaai:masterfrom
cc-cruz wants to merge 1 commit intocommaai:masterfrom
Conversation
rebased onto upstream/master; minimal diff
|
This branch is behind commaai/master. The line count diff bot is disabled. |
Contributor
|
cool refactor! in my experience, comma typically prefers smaller, focused PRs. i'd split this into two since they are separate improvements |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebased onto upstream/master; minimal diff
disclaimer: couldn’t find a matching web bounty card for this exact change. i wanted to get my feet wet with a small, safe performance improvement before picking up a bigger approved bounty. if appropriate, please attach this pr to the relevant web bounty/card from the board.
summary
changes
metrics (local prod build)
lighthouse (local prod preview http://localhost:5176, experimental preset)
verification
manual
risks
follow‑ups (optional)