feat: add Calendar component and replace mobile native date picker#139
Open
feat: add Calendar component and replace mobile native date picker#139
Conversation
Collaborator
🟡 Heimdall Review Status
🟡
|
| Code Owner | Status | Calculation | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| ui-systems-eng-team |
🟡
0/1
|
Denominator calculation
|
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
bdb2848 to
d88e834
Compare
hcopp
reviewed
Mar 3, 2026
hcopp
reviewed
Mar 3, 2026
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
d88e834 to
158cf94
Compare
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
158cf94 to
4b25572
Compare
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
hcopp
reviewed
Mar 5, 2026
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
12c3396 to
c7cf5a9
Compare
sverg-cb
changed the title
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
c7cf5a9 to
09e03c7
Compare
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
09e03c7 to
4ed26a2
Compare
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
4ed26a2 to
100b03a
Compare
New Features: * [Mobile] Standalone Calendar component cloned from cds-web and updated for cds-mobile Enhancements: * [Mobile] Comprehensive accessibility with screen reader support for Calendar component * [Mobile] Replaced react-native-date-picker with Calendar component for DatePicker * [Mobile + Web] Added/replaced calendar style props to match the new "classnames/styles" APIs * [Mobile] Added custom a11y labels for Calendar navigation Dependencies: * [Mobile] Remove react-native-date-picker (no longer needed) Tests: * [Mobile] Add Storybook for Calendar, including DatePicker, standalone, and custom triggers * [Mobile] Add unit tests for Calendar and DatePicker * [Web] Add slot styling examples for Calendar storybook Documentation: * [Mobile] Added mobile docs for Calendar * [Mobile + Web] Updated Calendar and DatePicker documentation to reflect the updated style APIs
sverg-cb
force-pushed
the
sverg/datepicker-mobile
branch
from
100b03a to
c4c11b1
Compare
hcopp
reviewed
Mar 10, 2026
| * @default 'Today' | ||
| */ | ||
| todayAccessibilityHint?: string; | ||
| }; |
Contributor
There was a problem hiding this comment.
Sorry for any confusion on this, we don't want to include the base props in common. We will just have them both inside of Calendar.tsx and DatePicker.tsx on web and mobile but they should match.
hcopp
reviewed
Mar 10, 2026
| */ | ||
| reduceMotion?: boolean; | ||
| /** Callback fired when the open animation completes. */ | ||
| onOpenComplete?: () => void; |
Contributor
Author
There was a problem hiding this comment.
regarding DatePicker, yes
hcopp
reviewed
Mar 10, 2026
| * announce state (e.g. "dimmed" on iOS) and do not activate on double-tap; | ||
| * touch/press is unchanged. | ||
| */ | ||
| accessibilityState?: AccessibilityState; |
Contributor
There was a problem hiding this comment.
Did we still plan on having tooltip changes? Thought those weren't needed.
hcopp
reviewed
Mar 10, 2026
| /** Custom class name for the date cell (CalendarPressable). */ | ||
| dayCellClassName?: string; | ||
| /** Custom style for the date cell (CalendarPressable). */ | ||
| dayCellStyle?: React.CSSProperties; |
Contributor
There was a problem hiding this comment.
We shouldn't have style/className one offs, it should all be inside of styles/classNames
hcopp
reviewed
Mar 10, 2026
| <Calendar | ||
| ref={calendarRef} | ||
| className={calendarClassName} | ||
| classNames={classNames?.calendar} |
Contributor
There was a problem hiding this comment.
Hmm I think we have been trying to flatten styles here but please check out Stepper, Select, and Carousel as those are newer components. Also not a big deal if someone can't customize the inner workings of calendar from a root, especially if we let them override it somehow. We could look at a "CalendarComponent" prop or something.
hcopp
reviewed
Mar 10, 2026
| disabled?: StyleProp<TextStyle>; | ||
| highlighted?: StyleProp<TextStyle>; | ||
| }; | ||
| }; |
Contributor
There was a problem hiding this comment.
We probably don't need this level of detail with dayCell and text.
hcopp
reviewed
Mar 10, 2026
| )} | ||
| </HStack> | ||
|
|
||
| <VStack style={styles?.content}> |
Contributor
There was a problem hiding this comment.
Do we need a separate VStack here? double check on web as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
New Features:
Enhancements:
accessibilityStateto Tooltip triggerDependencies:
Tests:
Documentation:
UI changes
Calendar
DatePicker
Accessibility
Using the Android Emulator with TalkBack
Screen_recording_20260309_130525.webm
Using a physical iPhone with VoiceOver
ScreenRecording_03-09-2026.14-34-23_1.MP4
Documentation
Testing
How has it been tested?
Testing instructions
For unit and interaction tests, use
yarn nx test mobile.Refer to the mobile-app docs for information on how to test via Expo.
View local Docusaurus changes with
yarn nx dev docs.Change management
type=routine
risk=low
impact=sev5
automerge=false