Resolve Failing Tests And Patch For Bounds in Linear Tree#179
Open
Resolve Failing Tests And Patch For Bounds in Linear Tree#179
Conversation
Adding a free disk space step since runners are running out of space for Github CI
Updating the dependencies to include onnxscript and the All-Things-Optimal fork that includes the fixes to match recent scikit-learn changes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #179 +/- ##
==========================================
+ Coverage 91.17% 91.19% +0.02%
==========================================
Files 39 39
Lines 3320 3386 +66
Branches 509 527 +18
==========================================
+ Hits 3027 3088 +61
- Misses 185 188 +3
- Partials 108 110 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…dependency issues
I had a need for tree surrogates with multiple outputs and OMLT did not support them. I have updated the LMDT definition and formulations to enable this. I have added some tests for this feature as well. This should be better than using multiple different trees on the same input space for different targets/outputs. It is compatible with the linear-tree package and the systems2atoms hyperplane trees that I have also been working on. Addresses issue #161 which is a request for this feature! **Legal Acknowledgement**\ By contributing to this software project, I agree my contributions are submitted under the BSD license. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer. **Legal Acknowledgement**\ By contributing to this software project, I agree my contributions are submitted under the BSD license. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer. Co-authored-by: Ethan Sunshine <93541000+emsunshine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses several issues that have resulted in failing tests as well as a patch for unscaled bounds in linear-tree. Here is everything that is addressed in this PR
Legal Acknowledgement
By contributing to this software project, I agree my contributions are submitted under the BSD license.
I represent I am authorized to make the contributions and grant the license.
If my employer has rights to intellectual property that includes these contributions,
I represent that I have received permission to make contributions and grant the required license on behalf of that employer.