🤖 fix: add heartbeat pattern to onChat for reliable stall detection #1909
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, stall detection used a 60s timeout while checking if a stream was active. This caused false positives during long tool operations (bash with 5+ min timeout, subagent calls) where it's normal to have no events. The retry would reset chat state and cause full UI repaints. Now the server sends heartbeats every 5s unconditionally, and the client expects *any* event within 10s. If 10s pass with no events (including heartbeats), the connection is dead and we resubscribe. Long operations no longer trigger false stalls since heartbeats keep flowing.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf90caa0c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a heartbeat pattern to the
onChatsubscription to reliably distinguish dead connections from intentionally idle streams during long operations.Background
The previous stall detection used a 60s timeout while checking if a stream was active. This caused false positives during long tool operations (bash with 5+ min timeout, subagent calls) where it's normal to have no events for extended periods. The retry would call
resetChatStateForReplay()which clears the aggregator and triggers a full UI repaint—noticeable and disruptive to users.Implementation
heartbeatevent every 5s unconditionally in theonChathandlerNow if 10s pass with no events (including heartbeats), the connection is genuinely dead → resubscribe. Long operations no longer trigger false stalls since heartbeats keep flowing.
Generated with
mux• Model:anthropic:claude-opus-4-5• Thinking:high• Cost:$1.30