feat(config): add SKSE Menu Framework menu by codepuncher · Pull Request #47 · codepuncher/HoldFast

codepuncher · 2026-06-07T19:07:55Z

Summary

add a HoldFast settings page to SKSE Menu Framework
let players change hold duration and Start/Back long-press actions in-game
keep settings persisted in HoldFast.ini

Copilot

Pull request overview

Adds optional integration with SKSE Menu Framework so players can edit HoldFast settings in-game while keeping persistence in HoldFast.ini. This fits into the plugin’s startup + input interception flow by centralizing INI parsing and adding a menu-driven settings surface.

Changes:

Refactors INI loading/parsing into a new HoldFast::Config module (load/save/apply/build buttons).
Adds HoldFastMenuUI integration (registers a Settings page; applies changes and persists to INI).
Updates input processing to avoid Start/Back interception while the Menu Framework UI is blocking input; updates build/docs to include the new dependency and instructions.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/Plugin.cpp	Switches startup config loading to `HoldFast::Config` and registers the menu integration.
src/PCH.h	Adds `<filesystem>` to PCH.
src/MenuUI.h	Declares Menu Framework integration API.
src/MenuUI.cpp	Implements Menu Framework registration, settings rendering, save/reload/reset, and “blocking input” detection.
src/InputHandler.cpp	Skips interception while the Menu Framework UI is blocking input.
src/Config.h	Declares settings model + config API (load/save/apply/parse/name).
src/Config.cpp	Implements INI read/write, action parsing, and handler application logic.
README.md	Documents optional in-game settings via SKSE Menu Framework.
docs/nexus-page.md	Mirrors README documentation for Nexus.
CMakeLists.txt	Adds new sources, include path for SKSE-MCP, and UNICODE defines.
.gitmodules	Adds `lib/skse-mcp` submodule.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Fixes linker failure in PLUGIN_TESTS_ONLY build (r3369989644). ParseAction and ActionName are moved from Config.cpp into a new ConfigParsing.cpp that compiles without SKSE headers. The test target gains ConfigParsing.cpp as a source and the PLUGIN_TESTS_ONLY compile definition to guard out the logger call and PCH inclusion.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

CMakeLists.txt:28

The unit-test target now includes config parsing/tests that pull in Config.h → InputHandler.h, but InputHandler.h depends on CommonLibSSE types (RE::...) and is not buildable in the current PLUGIN_TESTS_ONLY configuration (which only links Catch2 and doesn’t add CommonLibSSE include paths/targets). This will break cmake -DPLUGIN_TESTS_ONLY=ON builds.

Consider either (a) refactoring config parsing/types so they don’t depend on InputHandler/RE (e.g., a RE-free enum in HoldFast::Config plus mapping in the plugin), or (b) updating the tests CMake branch to add CommonLibSSE-NG (and any required compile defs/includes) so InputHandler.h can be compiled.

if(PLUGIN_TESTS_ONLY)

    find_package(Catch2 3 CONFIG REQUIRED)

    include(CTest)
    include(Catch)

    add_executable(${PROJECT_NAME}Tests test/PluginTests.cpp src/ConfigParsing.cpp)

    target_compile_definitions(${PROJECT_NAME}Tests PRIVATE PLUGIN_TESTS_ONLY)

    target_include_directories(${PROJECT_NAME}Tests PRIVATE "${CMAKE_CURRENT_SOURCE_DIR}/src")

    target_link_libraries(${PROJECT_NAME}Tests PRIVATE Catch2::Catch2WithMain)

…eAction

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.

Use SetSpaces(false) to match the existing no-space = style. Use fmt::format with {:g} instead of SetDoubleValue to avoid the %f six-decimal output (0.5 stays 0.5, not 0.500000).

… header Fixes two review comments (r3370054355, r3370054365, r3370054338, r3370054350). LongPressAction enum, ButtonConfig struct, and hold-duration constants are moved to src/LongPressAction.h (stdlib-only, no RE:: dependency). InputHandler.h includes it and adds using aliases so InputHandler::LongPressAction and InputHandler::ButtonConfig remain valid throughout the plugin code. Config.h replaces its InputHandler.h include with LongPressAction.h and a forward declaration of InputHandler, making config parsing headers RE-free — the PLUGIN_TESTS_ONLY build can now compile without CommonLibSSE. Also fixes None/NONE/etc triggering a spurious invalid-action warning: the guard now lowercases the raw value before comparing against 'none'.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.

feat(menu): add SKSE Menu Framework menu

35964e4

Copilot AI review requested due to automatic review settings June 7, 2026 19:07

Copilot started reviewing on behalf of codepuncher June 7, 2026 19:08 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/InputHandler.cpp Outdated

Comment thread src/MenuUI.cpp Outdated

Comment thread src/Config.cpp Outdated

Comment thread src/MenuUI.cpp

fix(menu): review changes

bfe086f

codepuncher requested a review from Copilot June 7, 2026 19:53

Copilot started reviewing on behalf of codepuncher June 7, 2026 19:53 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread test/PluginTests.cpp

Comment thread src/MenuUI.cpp

Comment thread src/Config.h

codepuncher added 2 commits June 7, 2026 21:30

fix(menu-ui): use backslash path in LoadLibraryW (r3369989651)

c8df503

Copilot AI review requested due to automatic review settings June 7, 2026 20:32

Copilot started reviewing on behalf of codepuncher June 7, 2026 20:32 View session

fix(config): add missing vector include to Config.h (r3369989658)

bf4040f

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/MenuUI.cpp

refactor(config): remove logWarnings param and ifdef guards from Pars…

d0f69ea

…eAction

Copilot AI review requested due to automatic review settings June 7, 2026 20:40

Copilot started reviewing on behalf of codepuncher June 7, 2026 20:40 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/MenuUI.cpp

Comment thread src/Config.cpp

Comment thread src/Config.cpp

Comment thread test/PluginTests.cpp

Comment thread src/Config.h

codepuncher added 2 commits June 7, 2026 21:50

fix(config): preserve INI format on save

ce6cd67

Use SetSpaces(false) to match the existing no-space = style. Use fmt::format with {:g} instead of SetDoubleValue to avoid the %f six-decimal output (0.5 stays 0.5, not 0.500000).

Copilot AI review requested due to automatic review settings June 7, 2026 21:00

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:00 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/PCH.h Outdated

Comment thread src/Plugin.cpp Outdated

Comment thread src/MenuUI.cpp Outdated

fix(plugin): remove unused includes and dead null-check

ff73bfb

codepuncher requested a review from Copilot June 7, 2026 21:09

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:09 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/MenuUI.cpp

Comment thread src/Config.cpp

fix(config): add cctype include and document menuFramework source

b2be64a

codepuncher requested a review from Copilot June 7, 2026 21:17

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:17 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/MenuUI.cpp

Comment thread src/MenuUI.cpp Outdated

fix(menu): remove per-frame allocs and align hold duration minimum

da44bff

codepuncher requested a review from Copilot June 7, 2026 21:28

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:28 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/Config.cpp

fix(config): log correct warning for below-minimum hold duration

89ae6c0

codepuncher requested a review from Copilot June 7, 2026 21:49

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:49 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

Comment thread src/InputHandler.cpp Outdated

fix(input): skip IsBlockingInput check when no buttons are tracked

04c0557

codepuncher requested a review from Copilot June 7, 2026 21:55

Copilot started reviewing on behalf of codepuncher June 7, 2026 21:55 View session

Copilot AI reviewed Jun 7, 2026

View reviewed changes

codepuncher changed the title ~~feat(menu): add SKSE Menu Framework menu~~ feat(config): add SKSE Menu Framework menu Jun 7, 2026

Conversation

codepuncher commented Jun 7, 2026

Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants