Fix type-checked rules#55
Merged
Merged
Conversation
matejchalk
added
🐛 bug
Tlacenka
approved these changes
Jun 24, 2026
Tlacenka
left a comment
Tlacenka
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for fixing this. 🚀
matejchalk
force-pushed
the
fix-ts-ignores
branch
from
80fb371 to
d1b0b6d
Compare
matejchalk
force-pushed
the
fix-ts-ignores
branch
from
d1b0b6d to
591e715
Compare
Tlacenka
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a major mistake I made in 3d1defa. 😅 My intention was to disable type-checked rules for non-TS files. However, because multiple file patterns are OR'ed, the negations matched every file.
Unit tests didn't catch this because they check if the rule is in the config, but that doesn't take into account explicitly disabled rules. I've strengthened the test assertions to check the configured level as well.